Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-studio): fix custom markers PTE example #7358

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

christianhg
Copy link
Contributor

Before this change, annotations would not be properly rendered in the editor. Instead of rendering the text element, the form for editing the annotation was rendered in the editor. This is clearly not intended and causes Slate to blow up when you try to focus the rendered form.


Can be tested here:

Annotated text before:
Screenshot 2024-08-12 at 13 51 37

Annotated text now:
Screenshot 2024-08-12 at 13 51 11

Before this change, annotations would not be properly rendered in the editor.
Instead of rendering the text element, the form for editing the annotation was
rendered in the editor. This is clearly not intended and causes Slate to blow
up when you try to focus the rendered form.
@christianhg christianhg requested a review from a team as a code owner August 12, 2024 11:55
@christianhg christianhg requested review from bjoerge and removed request for a team August 12, 2024 11:55
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 0:03am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 0:03am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 0:03am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 0:03am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Aug 12, 2024 0:03am
page-building-studio ⬜️ Skipped (Inspect) Aug 12, 2024 0:03am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Aug 12, 2024 12:11 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 23s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 49s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

@christianhg christianhg added this pull request to the merge queue Aug 12, 2024
Merged via the queue into next with commit 43b9969 Aug 12, 2024
41 checks passed
@christianhg christianhg deleted the chore-test-studio-fix-custom-markers-example branch August 12, 2024 13:12
cngonzalez pushed a commit that referenced this pull request Aug 20, 2024
Before this change, annotations would not be properly rendered in the editor.
Instead of rendering the text element, the form for editing the annotation was
rendered in the editor. This is clearly not intended and causes Slate to blow
up when you try to focus the rendered form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants