-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test-studio): fix custom markers PTE example #7358
Merged
christianhg
merged 1 commit into
next
from
chore-test-studio-fix-custom-markers-example
Aug 12, 2024
Merged
chore(test-studio): fix custom markers PTE example #7358
christianhg
merged 1 commit into
next
from
chore-test-studio-fix-custom-markers-example
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, annotations would not be properly rendered in the editor. Instead of rendering the text element, the form for editing the annotation was rendered in the editor. This is clearly not intended and causes Slate to blow up when you try to focus the rendered form.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
skogsmaskin
approved these changes
Aug 12, 2024
Component Testing Report Updated Aug 12, 2024 12:11 PM (UTC)
|
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
Before this change, annotations would not be properly rendered in the editor. Instead of rendering the text element, the form for editing the annotation was rendered in the editor. This is clearly not intended and causes Slate to blow up when you try to focus the rendered form.
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, annotations would not be properly rendered in the editor. Instead of rendering the text element, the form for editing the annotation was rendered in the editor. This is clearly not intended and causes Slate to blow up when you try to focus the rendered form.
Can be tested here:
Annotated text before:
Annotated text now: