feat(cli): update CLI to use new deploy endpoint #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 14, 2024 6:11 PM (UTC)
|
binoy14
reviewed
Jul 31, 2024
Co-authored-by: Carolina Gonzalez <carolina.nicole.gonzalez@gmail.com>
#7349) Co-authored-by: Rune Botten <rbotten@gmail.com>
cngonzalez
approved these changes
Aug 14, 2024
cngonzalez
added a commit
that referenced
this pull request
Aug 20, 2024
* feat(cli): update CLI to use new deploy endpoint * feat: restore streaming support * refactor: use client to stream instead of fetch * fix: use `urlType` for new API spec * fix(cli): fixes issues with deploying to new endpoint * fix(cli): fixes dependency issue * fix(core): fixes issue with depedency in tests * feat(cli): handle error statusCode from API * fix(cli): don't create default apps on deploy * feat(cli): add list of deployments on deploy * test: fix and add tests for new changes * fix: error handling and update copy * chore(cli): update copy Co-authored-by: Carolina Gonzalez <carolina.nicole.gonzalez@gmail.com> * feat(cli): add message about adding studioHost to cliConfig on deploys (#7349) Co-authored-by: Rune Botten <rbotten@gmail.com> --------- Co-authored-by: Binoy Patel <me@binoy.io> Co-authored-by: Carolina Gonzalez <carolina.nicole.gonzalez@gmail.com> Co-authored-by: Carolina Gonzalez <carolina@sanity.io> Co-authored-by: Rune Botten <rbotten@gmail.com>
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR cannot be merged until the newer deployment service is in prod.
Description
This PR introduces several key changes to the Sanity CLI:
studioHostSupport: Projects can now have multiplestudioHostconfigurations, allowing for multiple deployments under different hostnames. This is facilitated by the newstudioHostoption in the CLI configuration.getOrCreateUserApplication,createDeployment,deleteUserApplication, and others have been refactored and relocated to a separatehelpers.tsfile for better modularity and testability.form-datalib +nativefetchAPIclient.request: I added an additional commit that utilizes theform-datalibrary to re-enabling streaming of the tarball to the server instead of buffering all of it into memory.These changes are part of the larger multi-deploy studio project, aiming to enhance the deployment capabilities and flexibility of the Sanity CLI.
What to review
studioHostconfiguration option inCliConfig.studioHostvalues.deployAction,undeployAction, and the functions inhelpers.tsfor adequate coverage and correctness.deployAction.tsandundeployAction.tsfor adherence to best practices and consistency with the existing codebase.Testing
Extensive unit tests have been added and updated to cover:
studioHostconfigurations.These tests ensure that the changes are robust and handle various scenarios correctly. Please refer to the new test files and sections within existing tests for detailed coverage.
Note, the new service is not in prod yet so these changes have not been tested e2e yet.
Notes for release
TBD