Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct document ID validation #149

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: correct document ID validation #149

merged 1 commit into from
Mar 13, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Mar 9, 2023

The current document ID validation is a little too lenient:

  • Allows IDs that start with a dash
  • Allows double-dots (some..path)
  • Allows long IDs (max length is 128)

This PR fixes these issues.

@rexxars rexxars requested a review from stipsan March 9, 2023 17:05
stipsan
stipsan approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix 😌

@rexxars rexxars merged commit b5799c9 into main Mar 13, 2023
@rexxars rexxars deleted the fix/improve-document-id-validation branch March 13, 2023 15:20
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexxars @stipsan