fix(stega): remove try/catch block from stegaClean (#788)

sanity-io · May 3, 2024 · 06aaad2 · 06aaad2
1 parent b573f14
commit 06aaad2
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 6 deletions.
diff --git a/.github/workflows/browserslist.yml b/.github/workflows/browserslist.yml
@@ -25,6 +25,7 @@ jobs:
           private-key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }}
       - uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6
         with:
+          author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
           body: I ran `npx update-browserslist-db@latest` 🧑‍💻
           branch: actions/update-browserslist-database-if-needed
           commit-message: 'chore: update browserslist db'

diff --git a/.github/workflows/bun.yml b/.github/workflows/bun.yml
@@ -27,6 +27,7 @@ jobs:
           private-key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }}
       - uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6
         with:
+          author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
           body: I ran `bun install` 🧑‍💻
           branch: actions/maintain-bun-lock
           commit-message: 'chore(bun): update bun lockfile'

diff --git a/.github/workflows/deno.yml b/.github/workflows/deno.yml
@@ -31,6 +31,7 @@ jobs:
           private-key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }}
       - uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6
         with:
+          author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
           body: I ran `npm run test:deno:update_import_map` 🧑‍💻
           branch: actions/maintain-import-map
           commit-message: 'chore(deno): update import_map.json'

diff --git a/.github/workflows/prettier.yml b/.github/workflows/prettier.yml
@@ -37,6 +37,7 @@ jobs:
           private-key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }}
       - uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6
         with:
+          author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
           body: I ran `npx prettier --ignore-path .gitignore --cache --write .` 🧑‍💻
           branch: actions/prettier
           commit-message: 'chore(prettier): 🤖 ✨'

diff --git a/src/stega/stegaClean.ts b/src/stega/stegaClean.ts
@@ -6,11 +6,7 @@ import {vercelStegaClean} from '@vercel/stega'
  * @public
  */
 export function stegaClean<Result = unknown>(result: Result): Result {
-  try {
-    return vercelStegaClean<Result>(result)
-  } catch {
-    return result
-  }
+  return vercelStegaClean<Result>(result)
 }
 
 /**

diff --git a/test/stega/stegaClean.test.ts b/test/stega/stegaClean.test.ts
@@ -31,7 +31,6 @@ test('it handles strings', () => {
 test('it handles values that are not supported by JSON', () => {
   expect(stegaClean(undefined)).toMatchInlineSnapshot(`undefined`)
   expect(stegaClean(null)).toMatchInlineSnapshot(`null`)
-  expect(stegaClean(Symbol('foo'))).toMatchInlineSnapshot(`Symbol(foo)`)
   expect(stegaClean(new Set([1, 2, 3]))).toMatchInlineSnapshot(`{}`)
   expect(
     stegaClean(