Added the tests, code formatting changes, and the Range Request feature. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0fls
approved these changes
Jan 31, 2017
There was a problem hiding this comment.
I think this is overall good to go. In general, for a change this large, it would be nice to have minimum required changes (e.g. some of the formatting changes could have been included in a different MR). However, it's not that big of a deal and overall this looks like an improvement to me.
seemethere
approved these changes
Jan 31, 2017
|
Had to reconfigure some of the tests but I'll merge this feature even if the tests don't pass. |
seemethere
added a commit
to seemethere/sanic
that referenced
this pull request
Feb 9, 2017
seemethere
added a commit
that referenced
this pull request
Feb 9, 2017
Fixes errors related to #378
seemethere
added a commit
to seemethere/sanic
that referenced
this pull request
Feb 12, 2017
Changes from sanic-org#378 introduced about a 10k request/sec slowdown. This tries to rememdy it while keeping the same functionality but it's still not as fast as 0.3.1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.