Add ruff to toolchain #2865
Merged
Add ruff to toolchain #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL about ruff, looks like great tool. |
Absolutely, and I think we should and will get there. But, I wanted to make this a slower introduction first and avoid any sort of major diff heading into the LTS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2844 and #2843
It is a more mild approach than #2844 in that it does not implement any large changes to the code base right now, and keeps
bandit. I think both approaches in #2844 can be implemented over time, but I am in favor of a more gentle approach starting now, and moving towards that after the LTS.