Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow range requests for a single byte #2851

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Nov 16, 2023

It is OK to ask for one byte (end is inclusive). Apparently Chrome keeps doing this quite often.

@Tronic Tronic requested a review from a team as a code owner November 16, 2023 20:44
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5a9658) 88.387% compared to head (31a4064) 88.303%.
Report is 1 commits behind head on main.

❗ Current head 31a4064 differs from pull request most recent head be59262. Consider uploading reports for the commit be59262 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2851       +/-   ##
=============================================
- Coverage   88.387%   88.303%   -0.084%     
=============================================
  Files           92        92               
  Lines         7156      7156               
  Branches      1228      1228               
=============================================
- Hits          6325      6319        -6     
- Misses         575       582        +7     
+ Partials       256       255        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit 359bf4d into sanic-org:main Nov 28, 2023
24 checks passed
@Tronic Tronic deleted the ranges-off-by-one branch November 29, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants