Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for listener and signal prioritization #2822

Merged
merged 13 commits into from
Dec 9, 2023
Merged

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Sep 14, 2023

The purpose of this PR is to add priority to listeners and signals.

Requires: sanic-org/sanic-routing#76
Blocks: sanic-org/sanic-ext#228

@ahopkins ahopkins marked this pull request as ready for review December 9, 2023 19:29
@ahopkins ahopkins requested review from a team as code owners December 9, 2023 19:29
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (160ec7a) 88.217% compared to head (e8f2cd8) 88.232%.

Files Patch % Lines
sanic/app.py 81.818% 1 Missing and 1 partial ⚠️
sanic/mixins/listeners.py 94.736% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2822       +/-   ##
=============================================
+ Coverage   88.217%   88.232%   +0.014%     
=============================================
  Files           93        93               
  Lines         7282      7291        +9     
  Branches      1251      1253        +2     
=============================================
+ Hits          6424      6433        +9     
+ Misses         600       599        -1     
- Partials       258       259        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit 82bf46b into main Dec 9, 2023
26 checks passed
@ahopkins ahopkins deleted the priority-listeners branch December 9, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant