Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitHub Actions #2808

Merged
merged 20 commits into from
Aug 29, 2023
Merged

Refactor GitHub Actions #2808

merged 20 commits into from
Aug 29, 2023

Conversation

prryplatypus
Copy link
Member

@prryplatypus prryplatypus commented Aug 23, 2023

  • Simplifies all Tox actions by using a simple-tox action that does all the initial test setup transparently.
  • Merges all PR actions into a single pr-tests.yml file
  • Improves release flow merging PyPi and Docker release flow into publish-release.yml:
    • Package version gets injected into the package automatically when publishing to PyPi
    • Docker images get built after package is pushed to PyPi with the following tags (using Python 3.9 as an example):
      • 3.9-latest if the "Set as the latest release" checkbox is marked when creating a release
      • 3.9-YY.MM every time
      • 3.9-LTS if the release MM is 12

@prryplatypus prryplatypus requested a review from a team as a code owner August 23, 2023 17:33
@prryplatypus
Copy link
Member Author

Actions are failing because of #2807

@ahopkins
Copy link
Member

One thing I've also been thinking about doing is dropping codecov for a number of reasons, and simplifying to just use the coverage.py results. CI can create the HTML results and stash them as an artifact to display with maybe posting back a comment on the PR. WDYT?

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.028% 🎉

Comparison is base (31d1470) 88.783% compared to head (7046b8c) 88.811%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2808       +/-   ##
=============================================
+ Coverage   88.783%   88.811%   +0.028%     
=============================================
  Files           92        92               
  Lines         7052      7070       +18     
  Branches      1197      1212       +15     
=============================================
+ Hits          6261      6279       +18     
- Misses         542       544        +2     
+ Partials       249       247        -2     

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prryplatypus
Copy link
Member Author

prryplatypus commented Aug 23, 2023

One thing I've also been thinking about doing is dropping codecov for a number of reasons, and simplifying to just use the coverage.py results. CI can create the HTML results and stash them as an artifact to display with maybe posting back a comment on the PR. WDYT?

Could look into it, but I don't think it's possible to attach artifacts to a PR directly. However, maybe for a future PR?

@ChihweiLHBird
Copy link
Member

This refactor looks so great! Thanks for the effort!

ChihweiLHBird
ChihweiLHBird previously approved these changes Aug 27, 2023
Copy link
Member

@ChihweiLHBird ChihweiLHBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But I think it would be nicer if we can test the release in a fork of the repo.

.github/workflows/publish-release.yml Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
@prryplatypus
Copy link
Member Author

Looks good to me! But I think it would be nicer if we can test the release in a fork of the repo.

We did! There's a bunch of test releases in test pypi.org and in my Docker account (prryplatypus). :)

@ahopkins ahopkins merged commit 4dde457 into main Aug 29, 2023
27 checks passed
@ahopkins ahopkins deleted the actions-cleanup branch August 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants