-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub Actions #2808
Refactor GitHub Actions #2808
Conversation
Actions are failing because of #2807 |
One thing I've also been thinking about doing is dropping codecov for a number of reasons, and simplifying to just use the coverage.py results. CI can create the HTML results and stash them as an artifact to display with maybe posting back a comment on the PR. WDYT? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
=============================================
+ Coverage 88.783% 88.811% +0.028%
=============================================
Files 92 92
Lines 7052 7070 +18
Branches 1197 1212 +15
=============================================
+ Hits 6261 6279 +18
- Misses 542 544 +2
+ Partials 249 247 -2 ☔ View full report in Codecov by Sentry. |
Could look into it, but I don't think it's possible to attach artifacts to a PR directly. However, maybe for a future PR? |
This refactor looks so great! Thanks for the effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But I think it would be nicer if we can test the release in a fork of the repo.
We did! There's a bunch of test releases in test pypi.org and in my Docker account (prryplatypus). :) |
simple-tox
action that does all the initial test setup transparently.pr-tests.yml
filepublish-release.yml
:3.9-latest
if the "Set as the latest release" checkbox is marked when creating a release3.9-YY.MM
every time3.9-LTS
if the releaseMM
is12