Sanic on pypy

[deounix]

A small patch for the os module to make Sanic works with PyPy

The problem is that aiofiles uses os.readlink which doesn't exists on PyPy.

[codecov]

Codecov Report

Patch coverage: 100.000% and project coverage change: -0.052 ⚠️

Comparison is base (af67801) 88.938% compared to head (3c848f8) 88.887%.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #2682       +/-   ##
=============================================
- Coverage   88.938%   88.887%   -0.052%     
=============================================
  Files           92        92               
  Lines         6952      6956        +4     
  Branches      1185      1185               
=============================================
  Hits          6183      6183               
- Misses         527       529        +2     
- Partials       242       244        +2     

Impacted Files	Coverage Δ
sanic/application/logo.py	100.000% <100.000%> (ø)
sanic/application/motd.py	97.849% <100.000%> (ø)
sanic/asgi.py	91.729% <100.000%> (+0.062%)	⬆️
sanic/helpers.py	100.000% <100.000%> (ø)
sanic/log.py	100.000% <100.000%> (ø)
sanic/mixins/startup.py	92.753% <100.000%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ahopkins]

Nice find. Thanks.

[deounix]

@Tronic
@ahopkins

Updated. Thank you guys for the good work ( Sanic )

[Tronic]

Oh right, you can have UTF-8 codepage nowadays too. Still, the fix belongs upstream in Pypy, can you get it there?

[deounix]

Oh right, you can have UTF-8 codepage nowadays too. Still, the fix belongs upstream in Pypy, can you get it there?

I'm sorry I can't. If you could do it.

[Tronic]

Oh right, you can have UTF-8 codepage nowadays too. Still, the fix belongs upstream in Pypy, can you get it there?

I'm sorry I can't. If you could do it.

Nope, I never even used Pypy. I figured since you found the fix and solved the problem could make a PR or issue report to them as well. It would be very helpful to get this fixed for everybody, not just Sanic users.