-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanic on pypy #2682
Sanic on pypy #2682
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
=============================================
- Coverage 88.938% 88.887% -0.052%
=============================================
Files 92 92
Lines 6952 6956 +4
Branches 1185 1185
=============================================
Hits 6183 6183
- Misses 527 529 +2
- Partials 242 244 +2
☔ View full report in Codecov by Sentry. |
Nice find. Thanks. |
…tch_os monkeypatch
…tch_os monkeypatch
Co-authored-by: L. Kärkkäinen <98187+Tronic@users.noreply.github.com>
Oh right, you can have UTF-8 codepage nowadays too. Still, the fix belongs upstream in Pypy, can you get it there? |
I'm sorry I can't. If you could do it. |
Nope, I never even used Pypy. I figured since you found the fix and solved the problem could make a PR or issue report to them as well. It would be very helpful to get this fixed for everybody, not just Sanic users. |
A small patch for the
os
module to make Sanic works with PyPyThe problem is that
aiofiles
usesos.readlink
which doesn't exists on PyPy.