Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on duplicate route names #2525

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Warn on duplicate route names #2525

merged 1 commit into from
Aug 10, 2022

Conversation

ahopkins
Copy link
Member

Closes #2524

@ahopkins ahopkins requested a review from a team as a code owner August 10, 2022 05:27
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2525 (6f39cee) into main (2f6f2bf) will increase coverage by 0.065%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2525       +/-   ##
=============================================
+ Coverage   87.392%   87.457%   +0.065%     
=============================================
  Files           69        69               
  Lines         5560      5565        +5     
  Branches       966       969        +3     
=============================================
+ Hits          4859      4867        +8     
+ Misses         509       507        -2     
+ Partials       192       191        -1     
Impacted Files Coverage Δ
sanic/app.py 88.825% <100.000%> (+0.106%) ⬆️
sanic/server/protocols/http_protocol.py 83.823% <0.000%> (+2.205%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahopkins ahopkins merged commit 8e9342e into main Aug 10, 2022
@ahopkins ahopkins deleted the duplicate-route-names branch August 10, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Warn when multiple route names are the same
1 participant