Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanic#1480 Allow negative int/number in path #1481

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

endafarrell
Copy link
Contributor

I would like to be able to use possibly negative int and number values in routes.

This passes tests in:

  • python 3.5.6; with two skips in test_app.py
  • 3.6.8; also with two skips in test_app.py; and;
  • 3.7.2 without any skips.

I've rerun make beautify on my newly added tests.

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #1481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files          17       17           
  Lines        1730     1730           
  Branches      328      328           
=======================================
  Hits         1582     1582           
  Misses        123      123           
  Partials       25       25
Impacted Files Coverage Δ
sanic/router.py 95.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7d0f0...b752255. Read the comment docs.

Copy link
Contributor

@sjsadowski sjsadowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this and generally controversial changes get a fair bit of discussion. Given that it's gone a week without a peep, I'm going to approve and merge.

@sjsadowski sjsadowski merged commit b926a2c into sanic-org:master Feb 5, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants