Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove_entity_headers helper function #1415

Merged

Conversation

hramezani
Copy link
Contributor

Based on the comment on remove_entity_headers helper function:

Removes all the entity headers present in the headers given.
According to RFC 2616 Section 10.3.5,
Content-Location and Expires are allowed as for the
"strong cache validator".

Content-Location and Expires should be allowed.

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #1415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1415   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files          17       17           
  Lines        1704     1704           
  Branches      322      322           
=======================================
  Hits         1422     1422           
  Misses        217      217           
  Partials       65       65
Impacted Files Coverage Δ
sanic/helpers.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096c44b...bc89f45. Read the comment docs.

@hramezani hramezani force-pushed the fix_remove_entity_headers_helper branch from bc89f45 to 5bbd0b6 Compare November 17, 2018 21:51
@sjsadowski sjsadowski added this to the 18.12 LTS milestone Nov 19, 2018
@sjsadowski sjsadowski merged commit f7adc5f into sanic-org:master Nov 19, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants