Stop overzealous controlRodAdjustAmount adjustment amount adjustment #56
Conversation
Instead of looking for activly cooled reactors, I simply took the list size. Untested code, late night brainfart fix. TODO: Same for turbines.
This reverts commit 9fe6ed98194212bcf8c34063586e1b8ef3ebf375.
Instead of looking for activly cooled reactors, I simply took the list size. Untested code, late night brainfart fix. TODO: Same for turbines.
This reverts commit 9fe6ed98194212bcf8c34063586e1b8ef3ebf375.
It makes one reactor mess with the others. I guess it makes sense for one reactor setups to carry over between cycles, but as soon as there's more, you're in for surprises. More so since that variable is also used for the manual adjustment amount.
|
Wait, what? The individual reactors are all supposed to be loading and saving their own variables from their own config files. Was there a regression in config file functionality somewhere?? Date: Mon, 6 Apr 2015 22:26:54 -0700 The amount of the words "adjustment" and "amount" in the title needs to be adjusted. Nevertheless, from the commit message: It makes one reactor mess with the others. I guess it makes sense for one reactor setups to carry over between cycles, but as soon as there's more, you're in for surprises. More so since that variable is also used for the manual adjustment amount. Figured that out while I was testing the new UI handlers from thetaphi/minecraft_bigreactor_control@669e079 You can view, comment on, or merge this pull request online at: Commit Summary Count active reactors for steam capacity calculation File Changes Patch Links: https://github.com/sandalle/minecraft_bigreactor_control/pull/56.patch — |
|
AFAICT, that particular reactor setting slipped through the cracks from the start. I tried bisecting but couldn't find a good revision. So from what you say, a better approach than always leaving the adjustment value at 1 would be to a) kill the global and b) put the setting in the config file for each reactor via _G? |
Use the controlRodAdjustAmount value only as a default. Save it to the _G reactor options under "controlRodAdjustAmount", and use that instead for changing values.
Stop overzealous controlRodAdjustAmount adjustment amount adjustment
The amount of the words "adjustment" and "amount" in the title needs to be adjusted.
Nevertheless, from the commit message:
Figured that out while I was testing the new UI handlers from thetaphi/minecraft_bigreactor_control@669e079