Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Prettier for linting and autocorrecting the source code files #132

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #131

@jrgriffiniii jrgriffiniii force-pushed the issues-131-jrgriffiniii-prettier branch from 289ecae to 38d9b33 Compare November 17, 2022 14:48
@jrgriffiniii jrgriffiniii self-assigned this Nov 17, 2022
@jrgriffiniii jrgriffiniii force-pushed the issues-131-jrgriffiniii-prettier branch 2 times, most recently from 1b53101 to 478b026 Compare December 1, 2022 17:46
bess
bess previously requested changes Dec 7, 2022
Copy link
Member

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except for the table that isn't rendering.

README.md Outdated
| [samvera-circleci-orb](https://github.com/samvera/samvera-circleci-orb) | [![Build Status](https://circleci.com/gh/samvera/samvera-circleci-orb.svg?style=svg)](https://circleci.com/gh/samvera/samvera-circleci-orb) | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A |
| [valkyrie](https://github.com/samvera/valkyrie) | [![Build Status](https://circleci.com/gh/samvera/valkyrie.svg?style=svg)](https://circleci.com/gh/samvera/valkyrie) | | | 2.7.5 | 2.6.5 | | | 6.0.5 | 5.2.8 |
| [node-iiif](https://github.com/samvera/node-iiif) | [![Build Status](https://circleci.com/gh/samvera/node-iiif.svg?style=svg)](https://circleci.com/gh/samvera/node-iiif) | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A |
| [serverless-iiif](https://github.com/samvera/serverless-iiif) | [![Build Status](https://circleci.com/gh/samvera/serverless-iiif.svg?style=svg)](https://circleci.com/gh/samvera/serverless-iiif) | N/A | N/A | N/A | N/A | N/A | N/A | N/A | N/A |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table isn't rendering as expected, I don't think:

Screenshot 2022-12-07 at 2 41 10 PM

@jrgriffiniii jrgriffiniii force-pushed the issues-131-jrgriffiniii-prettier branch from 62725d6 to 5a6935b Compare December 13, 2022 14:51
@jrgriffiniii jrgriffiniii dismissed bess’s stale review December 13, 2022 14:52

Thank you very much for identifying this, I have just ensured that the table is now properly rendering.

@jrgriffiniii jrgriffiniii force-pushed the issues-131-jrgriffiniii-prettier branch from 5a6935b to 03cbe73 Compare December 13, 2022 14:54
@jrgriffiniii jrgriffiniii force-pushed the issues-131-jrgriffiniii-prettier branch from a01323a to 3ec1335 Compare December 13, 2022 15:59
@jrgriffiniii jrgriffiniii merged commit f59c8f4 into main Dec 13, 2022
@jrgriffiniii jrgriffiniii deleted the issues-131-jrgriffiniii-prettier branch December 13, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate Prettier for the linting of source code files
2 participants