Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow and build on Rails 7.1 #420

Merged
merged 2 commits into from
Nov 8, 2023
Merged

allow and build on Rails 7.1 #420

merged 2 commits into from
Nov 8, 2023

Conversation

jrochkind
Copy link
Contributor

No description provided.

@jrochkind
Copy link
Contributor Author

jrochkind commented Nov 8, 2023

Odd failures on Rails 7.1, may be test harness, not sure?

eg

  6) browse_everything/_files.html.erb a directory has the select-all checkbox
     Failure/Error: expect(page).to have_selector('input.ev-select-all')
     
     NoMethodError:
       undefined method `css' for "  <table id=\"file

…pybara::Node::Simple

The Capybara::Node::Simple method stopped working in Rails 7.1 for unknown reasons. But it turns out rails own assert_select is available here; while not looking like rspec style, it works, and is good enough, and supported, without figuring out a non-standard fragile solution.
@jrochkind
Copy link
Contributor Author

use standard Rails assert_select instead of trying to make our own Capybara::Node::Simple

The Capybara::Node::Simple method stopped working in Rails 7.1 for unknown reasons. But it turns out rails own assert_select is available here; while not looking like rspec style, it works, and is good enough, and supported, without figuring out a non-standard fragile solution.

@jrochkind
Copy link
Contributor Author

Thanks @jeremyf !

@jrochkind jrochkind merged commit 15b7de9 into main Nov 8, 2023
9 checks passed
@jrochkind jrochkind deleted the rails_7.1 branch November 8, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants