Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinguish between no samesite and samesite=none #240

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

colincasey
Copy link
Contributor

closes #191

@colincasey colincasey self-assigned this Jun 23, 2022
lib/cookie.js Show resolved Hide resolved
lib/cookie.js Show resolved Hide resolved
Copy link
Member

@awaterma awaterma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note for this p/r into the changelog for 4.1; we can do that in a separate p/r, but I think we may want to do it here so we don't miss the note on release.

@awaterma
Copy link
Member

@wjhsf -- anything holding us back here? Perhaps we can try and discuss in our meeting tomorrow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to distinguish between unspecified SameSite and SameSite=None
3 participants