Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Prism to Autoload languages #39

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Change Prism to Autoload languages #39

merged 2 commits into from
Sep 22, 2018

Conversation

tankerkiller125
Copy link
Contributor

Description

This pull request will allow Prism to automatically load all supported Prism languages from the official Prism CDN, this increases the currently supported list of languages from the very small amount to literally everything that prism can do.

This pull request also removes all languages except for the ones marked as "Core" on the Prism download site.

Test

N/A

Documentation Changes

I will make a pull request on the larecipe-docs repo after this request gets merged

Breaking Changes?

None, current functionality remains the same but is expanded to more languages.

@saleem-hadad
Copy link
Owner

Awesome 🔥
Thank you @tankerkiller125 for your contribution. You guys are amazing 😍

@saleem-hadad saleem-hadad merged commit aa934f7 into saleem-hadad:master Sep 22, 2018
@OwenMelbz
Copy link

@tankerkiller125 can you explain how to use this PR?

We've upgraded but now all our code blocks look like

code_standards-_giles

```php
// Don't
add_filter( 'hello', array( 1, 2, 3 ));

// Do
add_filter('hello', [1,2,3]);
```

@tankerkiller125
Copy link
Contributor Author

You should be able to use the markdown just like always, the prism autoload plugin will automatically go to prism CDN and retrieve the correct files.

@tankerkiller125
Copy link
Contributor Author

@OwenMelbz which browser are you using? And if you open the developers tools under network do you see the PRISM CDN request?

@OwenMelbz
Copy link

@tankerkiller125 yeah it was downloading it correctly, I think the problem was that the CSS required for the styling wasn’t hooking in.

I downloaded the css file on the lararecipe website and replaced and it fixed it.

So was almost like the source code version which was published didn’t support it maybe

@tankerkiller125
Copy link
Contributor Author

The source code version should be work properly, I published the CSS and JS change, so I'm really not sure what happened in your case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants