Fix failing configuration test #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a second argument to the `assertSee()` and `assertDontSee()` calls to prevent the double quote from being escaped to `"` and failing the test.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
ConfigurationTest::favicon_is_visible_only_if_ui_fav_is_settest is failing, also see the GitHub action run: https://github.com/saleem-hadad/larecipe/runs/494342595.The test is failing due to the fact that double quotes are currently escaped, comparing
"in the response to".Fix: disable escaping of double quotes in the assertion calls.
This PR adds a second argument to the
assertSee()andassertDontSee()calls to prevent the double quote from being escaped to".