SAK-50440 Rubrics remove sharing of public rubrics from other sites #12839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as a draft, as Christina requested that these actions should be shown only to superusers. We're working on that but we'd like to have this included in 25 so creating the PR before the freeze date. |
bgarciaentornos
requested changes
Sep 3, 2024
Comment on lines
80
to
82
| refreshPage() { | ||
| window.location.reload(); | ||
| } |
There was a problem hiding this comment.
This method is no longer used and it could be removed
…n case they are superusers
| @@ -19,6 +19,7 @@ save=Gorde | |||
| done=Egina | |||
| total=Guztira | |||
| confirm_remove=Ziur zaude kendu egin nahi duzula? | |||
| confirm_remove_public=Ziur "{}" publikoki partekatutako errubriketatik eta webgunearen jatorritik kendu nahi duzula? | |||
There was a problem hiding this comment.
@PabloSanRoman can you check this, please?
There was a problem hiding this comment.
Hi @bgarciaentornos!
Best with a little change:
- confirm_remove_public= Ziur kendu nahi duzula errubrika hau, "{}", publikoki partekatutako errubriketatik eta gunetik bertatik?
| this.fetchUserRoles(); | ||
| } | ||
|
|
||
| async fetchUserRoles() { |
There was a problem hiding this comment.
Please rename this to checkSuperUser (we're not actually getting other roles)
Comment on lines
21
to
22
| @GetMapping("/user/roles") | ||
| public ResponseEntity<Map<String, Boolean>> getUserRoles() { |
There was a problem hiding this comment.
Please rename this to checkSuperUser (we're not actually getting other roles)
…etUserRoles() method to checkSuperUser()
| const roles = await response.json(); | ||
| this.isSuperUser = roles.isSuperUser; | ||
|
|
||
| console.log("Is SuperUser:", this.isSuperUser); |
There was a problem hiding this comment.
Suggested change
| console.log("Is SuperUser:", this.isSuperUser); | |
| console.debug("Is SuperUser:", this.isSuperUser); |
bgarciaentornos
approved these changes
Sep 9, 2024
ern
changed the title
ern
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rubrics section, the public rubrics that are displayed must be able to be unpublished or deleted from any site other than the original. This is important for institutions with hundreds of shared rubrics or when the original instructor no longer belongs to the institution.
The development has been sponsored by Hotelschool.