Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50368 Discussions and Dropbox improve ui responsiveness #12792

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sharadhi98
Copy link
Contributor

Fixed the screen being too wide issue in the Discussions tool and the list of Dropboxes being too wide issue in the Dropbox tool.

overflow: hidden;
text-overflow: ellipsis;
}
.text-truncate{
white-space: normal !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Sharadhi98 is it possible to avoid using !important and rely on specificity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that text-truncate is a bootstrap class. i don't think it makes sense to override Bootstrap like this. if you don't like the use of text-truncate, the use of the class should be removed/altered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment. I will go through the code and try to avoid !important.

@@ -8,6 +8,9 @@
vertical-align: middle !important;
text-align:left !important;
}
.table td{
text-indent: 0em !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand this change. where is a text-indent being applied?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "List of Dropboxes" table within the student view, there was an inline CSS code for text-indent: 1 em. I had to override that by adding !important. I have attached two screenshots with and without the text-indent for your reference.
W:o text-indent
With text-indent

@jonespm jonespm self-requested a review August 15, 2024 23:21
@ern ern changed the title SAK-50368 Responsiveness of Discussions and Dropbox tools SAK-50368 Discussions and Dropbox improve ui responsiveness Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants