-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-50066 Date Manager export and import csv fixes #12714
base: master
Are you sure you want to change the base?
Conversation
if (announcement.getProperties().getProperty(AnnouncementService.RETRACT_DATE) != null) { | ||
changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RETRACT_DATE)), columns[3]); | ||
if (retractDateActive) { | ||
changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RETRACT_DATE)), releaseDateActive? columns[3] : columns[2]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed = changed || this.compareDates(Date.from(retractDateActive), releaseDateActive? columns[3] : columns[2]); ?
if (announcement.getProperties().getProperty(AnnouncementService.RELEASE_DATE) != null) { | ||
boolean releaseDateActive = announcement.getProperties().getProperty(AnnouncementService.RELEASE_DATE) != null; | ||
boolean retractDateActive = announcement.getProperties().getProperty(AnnouncementService.RETRACT_DATE) != null; | ||
if (releaseDateActive) { | ||
changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RELEASE_DATE)), columns[2]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed = changed || this.compareDates(Date.from(releaseDateActive ), columns[2]); ?
Hey @jesusmmp. I tried to apply the modifications that you suggest, but the problem is that the getInstantProperty cannot be null, and need to be incorporated after checked that exist |
3ade5d1
to
8e14eac
Compare
8e14eac
to
e0877a6
Compare
No description provided.