SAK-50187 Assignments Add visibility flag for gradebook item ui #12703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfish
force-pushed
the
SAK-50187
branch
2 times, most recently
from
c50d3bf
to
12d870f
Compare
ern
reviewed
Jul 16, 2024
Comment on lines
+278
to
+286
| @Transient | ||
| private Long gradebookCategory; | ||
|
|
||
| @Transient | ||
| private Boolean displayInGradebook = Boolean.FALSE; | ||
|
|
||
| @Transient | ||
| private Long newGbItemId = 0L; | ||
|
|
There was a problem hiding this comment.
Instead of adding transient fields it probably makes sense to create a different class which can hold the Assignment object as a field along with those above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50187