Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: remove no longer used JSValueConst type #499

Merged
merged 1 commit into from
Apr 22, 2024
Merged

misc: remove no longer used JSValueConst type #499

merged 1 commit into from
Apr 22, 2024

Conversation

saghul
Copy link
Owner

@saghul saghul commented Apr 22, 2024

No description provided.

@saghul saghul merged commit 4866fe9 into master Apr 22, 2024
14 checks passed
@saghul saghul deleted the no-jsvalueconst branch April 22, 2024 08:38
@chqrlie
Copy link

chqrlie commented Apr 22, 2024

This change is unfortunate, the JSValueConst is used to tell the programmer that the value is not consumed by the function call. The name is not perfect and a more explicit alternative is desirable, but removing the distinction between JSValue and JSValueConst is error-prone, it hides valuable information.

@saghul
Copy link
Owner Author

saghul commented Apr 22, 2024

I'll be happy to bring it back if / when we come up with a better replacement! Right now it was just noise and some casting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @chqrlie