Skip to content

Tweak actions runnners #890

Tweak actions runnners

Tweak actions runnners #890

GitHub Actions / clippy succeeded Apr 30, 2024 in 0s

clippy

14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 14
Note 0
Help 0

Versions

  • rustc 1.80.0-nightly (a8a1d3a77 2024-04-29)
  • cargo 1.80.0-nightly (b60a15551 2024-04-26)
  • clippy 0.1.79 (a8a1d3a 2024-04-29)

Annotations

Check warning on line 23 in src/config/redirect.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

warning: this `impl` can be derived
  --> src/config/redirect.rs:19:1
   |
19 | / impl Default for RedirectPolicy {
20 | |     fn default() -> Self {
21 | |         RedirectPolicy::None
22 | |     }
23 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]`
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
5  + #[derive(Default)]
6  | pub enum RedirectPolicy {
   |
help: ...and mark the default variant
   |
10 ~     #[default]
11 ~     None,
   |

Check warning on line 137 in src/config/dial.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/config/dial.rs:137:27
    |
137 |                 path.push(&s[5..].trim_start_matches('/'));
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `s[5..].trim_start_matches('/')`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 196 in src/trailer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric method

warning: usage of a legacy numeric method
   --> src/trailer.rs:196:45
    |
196 |             self.shared.ready.notify(usize::max_value());
    |                                             ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
    = note: `#[warn(clippy::legacy_numeric_constants)]` implied by `#[warn(clippy::all)]`
help: use the associated constant instead
    |
196 |             self.shared.ready.notify(usize::MAX);
    |                                             ~~~

Check warning on line 209 in src/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/handler.rs:209:32
    |
209 |         self.span.record("id", &id);
    |                                ^^^ help: change this to: `id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::all)]`

Check warning on line 308 in src/agent/selector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression borrows a value the compiler would automatically borrow

warning: this expression borrows a value the compiler would automatically borrow
   --> src/agent/selector.rs:308:9
    |
308 |         (&mut self.0[..bytes.len()]).copy_from_slice(bytes);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.0[..bytes.len()]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`

Check warning on line 149 in src/cookies/psl/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
   --> src/cookies/psl/mod.rs:149:11
    |
149 |         f(&*cache)
    |           ^^^^^^^ help: try: `&cache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 147 in src/cookies/psl/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
   --> src/cookies/psl/mod.rs:147:11
    |
147 |         f(&*cache)
    |           ^^^^^^^ help: try: `&cache`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
    = note: `#[warn(clippy::explicit_auto_deref)]` implied by `#[warn(clippy::all)]`

Check warning on line 133 in src/cookies/jar.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large

warning: the `Err`-variant returned from this function is very large
   --> src/cookies/jar.rs:133:10
    |
133 |     ) -> Result<Option<Cookie>, CookieRejectedError> {
    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
    |
    = help: try reducing the size of `cookies::jar::CookieRejectedError`, for example by boxing large elements or replacing it with `Box<cookies::jar::CookieRejectedError>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
note: the lint level is defined here
   --> src/lib.rs:235:5
    |
235 |     clippy::all
    |     ^^^^^^^^^^^
    = note: `#[warn(clippy::result_large_err)]` implied by `#[warn(clippy::all)]`

Check warning on line 140 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call` is never used

warning: method `call` is never used
   --> src/interceptor/mod.rs:140:24
    |
140 |                       fn call(&self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
    | |                                     -------- method in this trait
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 137 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call_mut` is never used

warning: method `call_mut` is never used
   --> src/interceptor/mod.rs:137:24
    |
137 |                       fn call_mut(&mut self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
    | |                        ----------- method in this trait
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 134 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call_once` is never used

warning: method `call_once` is never used
   --> src/interceptor/mod.rs:134:24
    |
134 |                       fn call_once(self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^^^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
    | |          ------------ method in this trait
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 140 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call` is never used

warning: method `call` is never used
   --> src/interceptor/mod.rs:140:24
    |
140 |                       fn call(&self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
    | |                                     -------- method in this trait
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 137 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call_mut` is never used

warning: method `call_mut` is never used
   --> src/interceptor/mod.rs:137:24
    |
137 |                       fn call_mut(&mut self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
    | |                        ----------- method in this trait
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 134 in src/interceptor/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `call_once` is never used

warning: method `call_once` is never used
   --> src/interceptor/mod.rs:134:24
    |
134 |                       fn call_once(self, $($arg: $arg_ty,)*) -> Self::Future;
    |                          ^^^^^^^^^
...
175 | /     impl_async_fn! {
176 | |         (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
    | |          ------------ method in this trait
177 | |         (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
178 | |         (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
179 | |     }
    | |_____- in this macro invocation
    |
note: the lint level is defined here
   --> src/lib.rs:234:5
    |
234 |     unused,
    |     ^^^^^^
    = note: `#[warn(dead_code)]` implied by `#[warn(unused)]`
    = note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)