Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Sygnum safe app recovery method [SW-168] #4166

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Feat: Sygnum safe app recovery method [SW-168] #4166

wants to merge 2 commits into from

Conversation

katspaugh
Copy link
Member

What it solves

Resolves https://www.notion.so/safe-global/Tweak-Recovery-Hub-UI-with-Sygnum-being-live-1b5bde2ee7a841568f05962d9d02c634

Screenshot 2024-09-12 at 16 23 28

How this PR fixes it

Sygnum Safe App will be released soon, so it becomes an active recovery option and not a waitlist.

How to test it

  • Go to Settings -> Security -> Recovery Setup
  • Choose Sygnum
  • Press Open App
  • Check analytics events

Checklist

  • [x ] I've documented how it affects the analytics (if at all) 📊

Copy link

github-actions bot commented Sep 12, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 940.46 KB (🟡 +26 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/security 8.06 KB (🟢 -2 B) 948.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.27% (+0.05% 🔼)
11940/15254
🔴 Branches
58.32% (+0.13% 🔼)
3054/5237
🟡 Functions
65.46% (+0.11% 🔼)
1888/2884
🟡 Lines
79.76% (+0.04% 🔼)
10777/13511
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
86.84% (-0.66% 🔻)
39.39% (+1.16% 🔼)
50%
86.11% (-0.73% 🔻)

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 4be6d0f

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Looks good!

@katspaugh katspaugh changed the title Feat: Sygnum safe app recovery method Feat: Sygnum safe app recovery method [SW-168] Sep 12, 2024
Copy link

@liliya-soroka
Copy link
Member

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

@liliya-soroka fixed ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA in progress
Development

Successfully merging this pull request may close these issues.

3 participants