fix: long token name visible over balance #4121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
| @@ -29,11 +29,13 @@ export const TransferTx = ({ | |||
| omitSign = false, | |||
| withLogo = true, | |||
| preciseAmount = false, | |||
| truncateText = false, | |||
There was a problem hiding this comment.
component is being used in various pages
truncate text is applied specifically to in transaction info component , to avoid unindented UI changes in other pages
There was a problem hiding this comment.
Didn't we decide to truncate text everywhere in #4034 (comment)?
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Safe-infra
added a commit
to safe-global/cla-signatures
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3438
How this PR fixes it
Truncate text for long token names
How to test it
1)Execute a transaction to transfer Erc20 (any) tokens via SafeWallet
2)Edit the token name via html to a long text ( alternatively deploy a token with long name and use it for transfer)
3)Token Name overlaps with other fields
Screenshots
Before :
Desktop :
Mobile :
After :
Desktop :
Mobile :
Checklist