Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong position function for campaign holder leaderboard #113

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix wrong position function for campaign holder leaderboard #113

merged 1 commit into from
May 21, 2024

Conversation

moisses89
Copy link
Member

Description

Get Campaign Leaderboard by holder was using the incorrect position function we must use RANK().

@moisses89 moisses89 requested a review from a team as a code owner May 21, 2024 13:53
@moisses89 moisses89 added the bug Something isn't working label May 21, 2024
@moisses89 moisses89 self-assigned this May 21, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9175892293

Details

  • 66 of 66 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 90.495%
Totals Coverage Status
Change from base Build 9172627363: 0.3%
Covered Lines: 1866
Relevant Lines: 2062
💛 - Coveralls

@moisses89 moisses89 merged commit 313c0fb into main May 21, 2024
5 checks passed
@moisses89 moisses89 deleted the fix_rank_for_position branch May 21, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@moisses89 moisses89

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moisses89 @coveralls @fmrsabino