Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Safe kit testing #911

Merged
merged 22 commits into from
Jul 20, 2024
Merged

feat: Safe kit testing #911

merged 22 commits into from
Jul 20, 2024

Conversation

yagopv
Copy link
Member

@yagopv yagopv commented Jul 16, 2024

What it solves

Resolves #869

How this PR fixes it

This PR add unit testing to safe-kit

@yagopv yagopv linked an issue Jul 16, 2024 that may be closed by this pull request
[SDK Refactoring] safe-kit testing #869
Closed
@coveralls
Copy link

coveralls commented Jul 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10018496750

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.5%) to 78.033%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/safe-kit/src/extensions/messages/offChainMessages.ts 0 2 0.0%
packages/safe-kit/src/extensions/messages/onChainMessages.ts 1 3 33.33%
packages/safe-kit/src/extensions/safe-operations/safeOperations.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 10010475373: 3.5%
Covered Lines: 936
Relevant Lines: 1125
💛 - Coveralls

@yagopv yagopv requested a review from dasanra July 17, 2024 08:32
@yagopv yagopv marked this pull request as ready for review July 17, 2024 08:32
@yagopv yagopv merged commit fbc4957 into development Jul 20, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
@dasanra dasanra deleted the feat/safe-kit-testing branch August 7, 2024 10:27
@dasanra dasanra restored the feat/safe-kit-testing branch August 7, 2024 10:29
@dasanra dasanra deleted the feat/safe-kit-testing branch September 16, 2024 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK Refactoring] safe-kit testing
3 participants
@yagopv @coveralls @dasanra