Fix signMessage and test against ganache #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germartinez
changed the title
|
CLA Assistant Lite All Contributors have signed the CLA. |
rmeissner
approved these changes
May 18, 2021
| const recoveredAddress = bufferToHex(pubToAddress(recoveredData)) | ||
| hasPrefix = !sameString(recoveredAddress, ownerAddress) | ||
| } catch (e) { | ||
| hasPrefix = true |
There was a problem hiding this comment.
Wouldn't it make more sense to throw? E.g. if we cannot recover it, something is probably wrong
| v: parseInt(signature.slice(130, 132), 16) | ||
| } | ||
| const recoveredData = ecrecover( | ||
| Buffer.from(txHash.slice(2), 'hex'), |
There was a problem hiding this comment.
Should we check this also for the prefixed hash and then throw if it matches neither? In the future we could this way also properly handle contract signatures
| @@ -11,6 +11,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "build": "yarn rimraf dist && hardhat compile && tsc", | |||
| "test:ganache": "export TEST_NETWORK=ganache && hardhat --network localhost deploy && nyc hardhat --network localhost test", | |||
There was a problem hiding this comment.
Should we run this in the CI?
mmv08
approved these changes
May 18, 2021
|
|
||
| async function getGanacheAccounts(): Promise<Account[]> { | ||
| const web3 = new Web3('http://localhost:8545') | ||
| const provider = new ethers.providers.Web3Provider(web3.currentProvider as any) |
tests/utils/setupConfig.ts
Outdated
| const provider = new ethers.providers.Web3Provider(web3.currentProvider as any) | ||
| const accounts: Account[] = [] | ||
| for (let i = 0; i < 10; i++) { | ||
| const signer: Signer = provider.getSigner(i) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signMessageit checks if the message had a prefix or not to adjust thevvalue accordinglyyarn test:ganacheto run the tests against ganache optionally