Extend Confirmation View with an optional value field #1851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
ConfirmationView
controller for staking "deposit" transaction confirmations. A newvalue
parameter was added to theTransactionDataDto
entity, in order to let clients include the value sent with the transaction when calling a payable smart contract method. This field is needed by the UI in order to inform the user in the confirmation screen about the amount of coins that are being staked.Changes
value
optional parameter toTransactionDataDto
.value
field to theNativeStakingConfirmationView
entity.