Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Confirmation View with an optional value field #1851

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

This PR extends the ConfirmationView controller for staking "deposit" transaction confirmations. A new value parameter was added to the TransactionDataDto entity, in order to let clients include the value sent with the transaction when calling a payable smart contract method. This field is needed by the UI in order to inform the user in the confirmation screen about the amount of coins that are being staked.

Changes

  • Adds value optional parameter to TransactionDataDto.
  • Adds value field to the NativeStakingConfirmationView entity.
  • Adjusts tests accordingly.

@hectorgomezv hectorgomezv self-assigned this Aug 26, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner August 26, 2024 14:38
@hectorgomezv hectorgomezv merged commit b1233d3 into main Aug 26, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the extend-confirmation-view branch August 26, 2024 14:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10561835995

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 46.769%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/common/entities/transaction-data.dto.entity.ts 2 3 66.67%
src/routes/transactions/entities/staking/native-staking-confirmation-view.entity.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 10557486739: -0.002%
Covered Lines: 4742
Relevant Lines: 8201

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend /views/transaction-confirmation endpoint payload with an optional value field
2 participants