New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new `Campaign` fields #1836

Merged

hectorgomezv merged 1 commit into main from campaign-fields

Aug 21, 2024

Member

iamacook commented Aug 20, 2024

Summary

This adds the new Campaign fields to the relative entities/schemas.

Changes

Extends CampaignSchema:
- rewardValue - numeric string
- rewardText - nullable string
- iconUrl - nullable string URL
- safeAppUrl - nullable string URL
- partnerUrl - nullable string URL
- isPromoted - boolean
Extend route Campaign entity
Extend campaignBuilder builder
Add relative test coverage


          Add new Campaign fields

588a234

iamacook self-assigned this

iamacook requested a review from a team as a code owner

August 20, 2024 13:25

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10472501152

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 46.709%

Totals
Change from base Build 10471489493:	0.03%
Covered Lines:	4633
Relevant Lines:	8008

💛 - Coveralls

hectorgomezv approved these changes

View reviewed changes

hectorgomezv merged commit 5cd1137 into main

16 checks passed

hectorgomezv deleted the campaign-fields branch

August 21, 2024 16:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet