Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account data types #1708

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Add account data types #1708

merged 5 commits into from
Jul 2, 2024

Conversation

hectorgomezv
Copy link
Member

@hectorgomezv hectorgomezv commented Jul 1, 2024

Summary

This PR adds the endpoint:

GET /v1/accounts/data-types

The response of this endpoint is expected to be an array holding the AccountDataType items available, and specifying if whether they are active.

[
    {
        "dataTypeId": "1",
        "name": "CounterfactualSafes",
        "description": "Counterfactual Safes",
        "isActive": true
    },
    {
        "dataTypeId": "2",
        "name": "AddressBook",
        "description": "Address Book",
        "isActive": false
    },
    {
        "dataTypeId": "3",
        "name": "Watchlist",
        "description": "Watchlist",
        "isActive": false
    }
]

Changes

  • The endpoint GET /v1/data-types was added to AccountsController.
  • Associated tests and domain classes were added.

@hectorgomezv hectorgomezv self-assigned this Jul 1, 2024
@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9747030551

Details

  • 8 of 18 (44.44%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 48.597%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasources/accounts/accounts.datasource.ts 0 1 0.0%
src/domain/accounts/accounts.repository.ts 0 1 0.0%
src/routes/accounts/accounts.controller.ts 2 3 66.67%
src/routes/accounts/entities/account-data-type.entity.ts 5 8 62.5%
src/routes/accounts/accounts.service.ts 1 5 20.0%
Totals Coverage Status
Change from base Build 9743387820: -0.05%
Covered Lines: 4210
Relevant Lines: 6988

💛 - Coveralls

@hectorgomezv hectorgomezv marked this pull request as ready for review July 2, 2024 07:33
@hectorgomezv hectorgomezv requested a review from a team as a code owner July 2, 2024 07:33
@hectorgomezv hectorgomezv merged commit cba4fb4 into main Jul 2, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-account-data-types branch July 2, 2024 07:37
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9756811070

Details

  • 9 of 20 (45.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 48.597%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/datasources/accounts/accounts.datasource.ts 0 1 0.0%
src/domain/accounts/accounts.repository.ts 0 1 0.0%
src/routes/accounts/accounts.controller.ts 2 3 66.67%
src/routes/accounts/accounts.service.ts 1 5 20.0%
src/routes/accounts/entities/account-data-type.entity.ts 6 10 60.0%
Totals Coverage Status
Change from base Build 9756629636: -0.05%
Covered Lines: 4211
Relevant Lines: 6990

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants