Fix getNumberString utils function #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
commented
Jun 28, 2024
| @@ -1,6 +1,7 @@ | |||
| export function getNumberString(value: number): string { | |||
| // Prevent scientific notation | |||
| return value.toLocaleString('fullwide', { | |||
There was a problem hiding this comment.
'fullwide' is not a standard locale identifier. This seems to be a bug in the original implementation, which JS is probably ignoring and therefore defaulting to the host locale.
Pull Request Test Coverage Report for Build 9713953727Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1701
Changes
getNumberStringimplementation to use a fixed locale, standard notation, and no grouping.