Simplify and use AbiDecoder
function selector helpers
#1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were generating
AbiDecoder['helpers']
by decoding function data and returningtrue
/false
according to what it decodes. A more efficient method is comparing the beginning of the data against the function selector.This adjusts the logic of
AbiDecoder['helpers']
to instead compare the beginning of the function data against the relevant selector.Changes
AbiDecoder['helpers']
generationSetPreSignatureDecoder['isSetPreSignature']
and replace all usage withthis.helpers.isSetPreSignature