Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FF_COUNTERFACTUAL_BALANCES #1625

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

hectorgomezv
Copy link
Member

Summary

Counterfactual balances are being retrieved when the Safe doesn't exist (it is not known by the Safe Transaction Service). This PR set that as an optional behavior, so the existence of a Safe and the use of an alternative source for the balances associated can be (de)activated via this FF.

Changes

  • Adds FF_COUNTERFACTUAL_BALANCES feature flag.

@hectorgomezv hectorgomezv self-assigned this Jun 10, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner June 10, 2024 11:25
@hectorgomezv hectorgomezv enabled auto-merge (squash) June 10, 2024 11:30
@hectorgomezv hectorgomezv merged commit da063e4 into main Jun 10, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-counterfactual-balances-ff branch June 10, 2024 11:31
@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9447473695

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 92.717%

Files with Coverage Reduction New Missed Lines %
src/datasources/balances-api/zerion-balances-api.service.ts 4 81.9%
Totals Coverage Status
Change from base Build 9444680700: 0.02%
Covered Lines: 7127
Relevant Lines: 7388

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9447499865

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 92.697%

Files with Coverage Reduction New Missed Lines %
src/datasources/balances-api/zerion-balances-api.service.ts 4 81.9%
Totals Coverage Status
Change from base Build 9444680700: -0.003%
Covered Lines: 7128
Relevant Lines: 7388

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants