Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load a Safe from owner #313

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Nov 23, 2023

Description

This pull request introduces the capability to load the safe-cli from an owner's address. The process involves:

  • Executing safe-cli with the --get-safes-from-owner option.
  • The safe-cli displays the available Safe addresses associated with the provided owner.
  • Upon selection, the safe-cli loads the chosen safe.

More changes

  • Change safe_address argument to address that can be a Safe address or an owner address
  • Add option get-safes-from-owner to indicate if the provided address is an owner

Related issues

This implementation can be used with any type of owner and also to check if a Safe is an owner of other Safes.
Closes #13

@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 93.371% (+0.3%) from 93.053%
when pulling 89f831c on add_owner_initializer
into b9fba90 on master.

@moisses89 moisses89 force-pushed the add_owner_initializer branch 4 times, most recently from da0c742 to f848c69 Compare November 23, 2023 12:04
@moisses89 moisses89 marked this pull request as ready for review November 23, 2023 12:14
README.md Outdated Show resolved Hide resolved
safe_cli/main.py Outdated Show resolved Hide resolved
safe_cli/main.py Outdated Show resolved Hide resolved
safe_cli/main.py Outdated Show resolved Hide resolved
safe_cli/main.py Outdated Show resolved Hide resolved
@moisses89 moisses89 force-pushed the add_owner_initializer branch 2 times, most recently from 210cb92 to 1f9465d Compare November 27, 2023 12:52
safe_cli/main.py Outdated Show resolved Hide resolved
safe_cli/main.py Outdated Show resolved Hide resolved
safe_cli/utils.py Outdated Show resolved Hide resolved
@moisses89 moisses89 force-pushed the add_owner_initializer branch 2 times, most recently from f141145 to 0b1903e Compare November 27, 2023 16:30
@moisses89 moisses89 requested a review from Uxio0 November 27, 2023 16:30
@moisses89 moisses89 merged commit 8a070ec into master Nov 28, 2023
13 checks passed
@moisses89 moisses89 deleted the add_owner_initializer branch November 28, 2023 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Safes that the current Safe is owner of
3 participants