Parse chapters #19
Draft
Parse chapters #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saecki
force-pushed
the
chapters
branch
4 times, most recently
from
037ef93
to
061653e
Compare
saecki
force-pushed
the
chapters
branch
2 times, most recently
from
7200d0b
to
61f03d2
Compare
saecki
force-pushed
the
chapters
branch
3 times, most recently
from
c4f0206
to
ed50e7e
Compare
saecki
force-pushed
the
chapters
branch
2 times, most recently
from
8090eb8
to
f109050
Compare
saecki
force-pushed
the
chapters
branch
2 times, most recently
from
8f56855
to
2ddcd0b
Compare
The state will be used when writing atoms:
1. Read existing structure
2. Check and insert new/update atom and their states
3. Collect changes recursively a vec
Possible changes:
- update length
- insert new atom
- replace existing atom
4. Sort changes by position
5. Apply changes
|
I've tried this branch in an application and it seems to work great. Looking forward to this being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to implement parsing chapters of
traks, as requested in #18.