Wip/perf/memory #546
Merged
Wip/perf/memory #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf: ValueDisplayListener doesn't regenerate interpolated data source per query
…Dtool) or delayed
…zation should happen across blocks
This is a memory optimization. when downsampling LMT over a cached cell image, empty blocks at higher resolution levels are still created as full-sized backing VolatileLabelMultisetArray data. This is needed for writing, but in this case, it allocates a lot of memory, and holds on for it long enough that it can cause Heap memory issues. To this end, the downsampler cell can now return empty blocks, indicated by VolatileLabelMultisetArray data with size 0. In this case, we can just skip the block, which saves iterations as well.
…Url with `/` closes #545
fix(test): labelblocklookup serialization test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.