Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging error font-patcher #1287

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fix logging error font-patcher #1287

merged 2 commits into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. Fix typo in font-patcher.

    llc0930 committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3d4d843 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. font-patcher: Unify logging calls [skip ci]

    [why]
    Usually the variable `logger` holds the logger object and all logging
    calls got through that.
    
    But because we use the font filename as loggername that logger object
    can only be set up after the arguments have been parsed. If some
    messages are to be logged before the call needs to go to the root logger
    called as `logging` class.
    
    This means one needs to take `logger` or `logging` based on the time
    when someting is to be logged. That can be confusing and is easily
    wrong, especially if code is shifted.
    
    [how]
    Always use the `logger` variable and just let that point to the root
    logger until we set up a concrete logger.
    
    Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    Finii committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    bf2c338 View commit details
    Browse the repository at this point in the history