Fix Default Alpha Blending On WebGL #608
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This addresses issue #606
Unlike normal OpenGL, WebGL expects colours' RGB values to be premultiplied by their alpha value. Meeting this expectation is fairly straight forward, as it can be achieved simply by modifying the fragment shader exclusively for wasm32 architecture.
Unfortunately the usual blend func
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA)
isn't going to do what you'd expect thanks to this, and so I've changed it to
blendFunc(GL_ONE, GL_ONE_MINUS_SRC_ALPHA)
by default on wasm32 arch. It might make more sense to apply this change toglow
orgolem
, rather thanquicksilver
, but I'm not all too familiar with the ecosystem so this could probably use some discussion.Checks
CONTRIBUTING.md
CHANGES.md
, with [BREAKING] next to all breaking changes