Create the 'input' module to replace 'lifecycle' #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the 'lifecycle' concept is less important than in previous versions. There is just a single 'run' function that takes a Settings instance and a closure, instead of a whole mess of behind-the-scenes work. Most of the 'lifecycle' module (with the exception of a few Window functions) is just about receiving input from the user. The new name makes this more clear. Additionally, there were some ergonomic issues with re-exporting blinds structures rather than wrapping them in new code. Primarily, this required understanding "what is the mint crate" and "why do I care" and "how do I use it." End users of Quicksilver shouldn't have to concern themselves with this, so these parts of the blinds API have been wrapped over. The Settings struct also needed to be decoupled from blinds. There are more settings than just window management (for example, disable searching for 'static/' assets) so there are now Quicksilver-specific Settings. The old module and its members have been left around for convenience, because the alpha frequently requires updating for new features or critical bugfixes. However, they are strongly deprecated and will be subject to removal before beta.
43 tasks
Also, re-export Graphics and Input at the top level. They are needed in literally every Quicksilver application, because you need to name the types to run 'app.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the 'lifecycle' concept is less important than in previous
versions. There is just a single 'run' function that takes a Settings
instance and a closure, instead of a whole mess of behind-the-scenes
work. Most of the 'lifecycle' module (with the exception of a few Window
functions) is just about receiving input from the user. The new name
makes this more clear.
Additionally, there were some ergonomic issues with re-exporting blinds
structures rather than wrapping them in new code. Primarily, this
required understanding "what is the mint crate" and "why do I care" and
"how do I use it." End users of Quicksilver shouldn't have to concern
themselves with this, so these parts of the blinds API have been wrapped
over.
The Settings struct also needed to be decoupled from blinds. There are
more settings than just window management (for example, disable
searching for 'static/' assets) so there are now Quicksilver-specific
Settings.
The old module and its members have been left around for convenience,
because the alpha frequently requires updating for new features or
critical bugfixes. However, they are strongly deprecated and will be
subject to removal before beta.
Motivation and Context
See #552 for some individual fixes.
Resolves #586
Checks
CHANGES.md, with [BREAKING] next to all breaking changesREADME.mdcompiles and functions like expected