Fix the default blending #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Default::default of an Option is None, which disables blending. That line was supposed to enable the default blending mode in golem, which is a sensible blending default.
43 tasks
|
Confirmed fix 👍 |
leod
pushed a commit
to leod/quicksilver
that referenced
this pull request
Jun 3, 2023
The Default::default of an Option is None, which disables blending. That line was supposed to enable the default blending mode in golem, which is a sensible blending default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Default::default of an Option is None, which disables blending. That
line was supposed to enable the default blending mode in golem, which is
a sensible blending default, instead of disabling blending entirely.
Motivation and Context
See #552 (comment)
Checks
CONTRIBUTING.md.CHANGES.md, with [BREAKING] next to all breaking changes