Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict image formats to png and jpeg #558

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

ryanisaacg
Copy link
Owner

@ryanisaacg ryanisaacg commented Jan 8, 2020

Also update image to 0.22 from 0.21, and remove the jpeg rayon feature.
This may take some perf hit on desktop, but it removes unnecessary
complexity and makes jpeg work on web.

Now that image isn't depended on by winit, there's no other crate
toggling on default features accidentally. Removing the rayon feature
actually removes it!

Motivation and Context

See discussion of image formats in #552
Resolves #508

Checks

  • I have updated CHANGES.md, with [BREAKING] next to all breaking changes
  • I have updated the documentation if necessary

Also update image to 0.22 from 0.21, and remove the jpeg rayon feature.
This may take some perf hit on desktop, but it removes unnecessary
complexity and makes jpeg work on web.

Now that image isn't depended on by winit, there's no other crate
toggling on default features accidentally. Removing the rayon feature
actually removes it!

Resolves #508
@ryanisaacg ryanisaacg merged commit 4a49a6a into master Jan 8, 2020
@ryanisaacg ryanisaacg deleted the restrict-image-formats branch January 8, 2020 18:38
@paulirotta
Copy link
Contributor

I tried backporting this fix to 0.3 but without joy.

Could you update the sound-is-working branch for us or point what I missed? Thanks- loving the lib.

https://github.com/paulirotta/quicksilver/tree/image-fix-test

leod pushed a commit to leod/quicksilver that referenced this pull request Jun 3, 2023
Also update image to 0.22 from 0.21, and remove the jpeg rayon feature.
This may take some perf hit on desktop, but it removes unnecessary
complexity and makes jpeg work on web.

Now that image isn't depended on by winit, there's no other crate
toggling on default features accidentally. Removing the rayon feature
actually removes it!

Resolves ryanisaacg#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading a jpg image causes a panic in WASM
2 participants