Remove defaults #107
Remove defaults #107
Conversation
| @@ -120,19 +119,21 @@ To pass several timeseries, we can use: | |||
| import pandas as pd | |||
| idx = pd.date_range("2023", freq="YS", periods=2) | |||
| # --- hide: stop --- | |||
| pd.DataFrame({"p": [50, 56], "w": [120, 125]}, idx) | |||
| df = pd.DataFrame(dict_of_tseries) | |||
There was a problem hiding this comment.
I think you'll need to re-define the dict_of_tseries object for this to work.
portfolyo/core/pfline/interop.py
Outdated
| @@ -49,16 +50,15 @@ class InOp: | |||
| p: tools.unit.Q_ | pd.Series = None | |||
| r: tools.unit.Q_ | pd.Series = None | |||
| nodim: tools.unit.Q_ | pd.Series = None # explicitly dimensionless | |||
| agn: float | pd.Series = None # agnostic | |||
| agn: float | pd.Series = None # agnostic TODO factor out | |||
There was a problem hiding this comment.
this can be removed yet maybe?
| return create.flatpfline( | ||
| pd.DataFrame( | ||
| { | ||
| "q": [Q_(0, "MWh") for _ in range(len(ref_idx))], |
There was a problem hiding this comment.
Here it's probably faster to do pd.DataFrame({'q': pd.Series(0, ref_idx, dtype='pint[MWh]', 'r': pd.Series(0, ref_idx, dtype='pint[Eur]'})
There was a problem hiding this comment.
not so easy to adapt tests to this change, didn't have time to change
portfolyo/tools/unit.py
Outdated
| @@ -36,21 +36,31 @@ | |||
| "nodim": ureg.dimensionless, | |||
| } | |||
|
|
|||
| NAMES_AND_DIMENSIONS = { | |||
| "w": ureg.MW.dimensionality, | |||
There was a problem hiding this comment.
Can we get rid of the specific units?
{
'w': ureg.get_dimensionality({'[energy]': 1, '[time]': -1}),
'q': ureg.get_dimensionality({'[energy]': 1}),
'p': ureg.get_dimensionality({'[currency]': 1, '[energy]': -1}),
'r': ureg.get_dimensionality({'[currency]': 1}),
'duration': ureg.get_dimensionality({'[time]': 1}),
't': ureg.get_dimensionality({'[temperature]': 1}),
'nodim': ureg.get_dimensionality({}),
}
| # } | ||
|
|
||
|
|
||
| def get_value( |
There was a problem hiding this comment.
Is there a reason why this function is defined here, instead of changing and using the function in dev?
There was a problem hiding this comment.
not really, changed the location
📚 Documentation preview 📚: https://portfolyo--107.org.readthedocs.build/en/107/