Skip to content

Commit

Permalink
lib,test: update let to const where applicable
Browse files Browse the repository at this point in the history
As per the `prefer-const` eslint rule, few instances of `let` have been
identified to be better with `const`. This patch updates all those
instances.

Refer: nodejs#3118
PR-URL: nodejs#3152
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
  • Loading branch information
thefourtheye authored and rvagg committed Oct 29, 2015
1 parent 701e38c commit 6e887cc
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 20 deletions.
2 changes: 1 addition & 1 deletion lib/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ function masterInit() {
var match = execArgv[i].match(/^(--debug|--debug-(brk|port))(=\d+)?$/);

if (match) {
let debugPort = process.debugPort + debugPortOffset;
const debugPort = process.debugPort + debugPortOffset;
++debugPortOffset;
execArgv[i] = match[1] + '=' + debugPort;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ function formatCollectionIterator(ctx, value, recurseTimes, visibleKeys, keys) {
var nextRecurseTimes = recurseTimes === null ? null : recurseTimes - 1;
var vals = mirror.preview();
var output = [];
for (let o of vals) {
for (const o of vals) {
output.push(formatValue(ctx, o, nextRecurseTimes));
}
return output;
Expand Down
13 changes: 7 additions & 6 deletions test/parallel/test-async-wrap-check-providers.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,17 @@ process.on('SIGINT', () => process.exit());

// Run from closed net server above.
function checkTLS() {
let options = {
const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/ec-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/ec-cert.pem')
};
let server = tls.createServer(options, noop).listen(common.PORT, function() {
tls.connect(common.PORT, { rejectUnauthorized: false }, function() {
this.destroy();
server.close();
const server = tls.createServer(options, noop)
.listen(common.PORT, function() {
tls.connect(common.PORT, { rejectUnauthorized: false }, function() {
this.destroy();
server.close();
});
});
});
}

zlib.createGzip();
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-zero-fill-reset.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ function testUint8Array(ui) {

for (let i = 0; i < 100; i++) {
new Buffer(0);
let ui = new Uint8Array(65);
const ui = new Uint8Array(65);
assert.ok(testUint8Array(ui), 'Uint8Array is not zero-filled');
}
2 changes: 1 addition & 1 deletion test/parallel/test-http-flush-headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ server.on('request', function(req, res) {
server.close();
});
server.listen(common.PORT, '127.0.0.1', function() {
let req = http.request({
const req = http.request({
method: 'GET',
host: '127.0.0.1',
port: common.PORT,
Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-http-response-multiheaders.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ const norepeat = [
const server = http.createServer(function(req, res) {
var num = req.headers['x-num'];
if (num == 1) {
for (let name of norepeat) {
for (const name of norepeat) {
res.setHeader(name, ['A', 'B']);
}
res.setHeader('X-A', ['A', 'B']);
} else if (num == 2) {
let headers = {};
for (let name of norepeat) {
const headers = {};
for (const name of norepeat) {
headers[name] = ['A', 'B'];
}
headers['X-A'] = ['A', 'B'];
Expand All @@ -44,7 +44,7 @@ server.listen(common.PORT, common.mustCall(function() {
{port:common.PORT, headers:{'x-num': n}},
common.mustCall(function(res) {
if (n == 2) server.close();
for (let name of norepeat) {
for (const name of norepeat) {
assert.equal(res.headers[name], 'A');
}
assert.equal(res.headers['x-a'], 'A, B');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-tls-socket-default-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function testSocketOptions(socket, socketOptions) {
setImmediate(runTests);
});
}).listen(common.PORT, function() {
let c = new tls.TLSSocket(socket, socketOptions);
const c = new tls.TLSSocket(socket, socketOptions);
c.connect(common.PORT, function() {
c.end(sent);
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-util-inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ map.set(1, 2);
var mirror = Debug.MakeMirror(map.entries(), true);
var vals = mirror.preview();
var valsOutput = [];
for (let o of vals) {
for (const o of vals) {
valsOutput.push(o);
}

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-zlib-truncated.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ const inputString = 'ΩΩLorem ipsum dolor sit amet, consectetur adipiscing el'
].forEach(function(methods) {
zlib[methods.comp](inputString, function(err, compressed) {
assert(!err);
let truncated = compressed.slice(0, compressed.length / 2);
const truncated = compressed.slice(0, compressed.length / 2);

// sync sanity
assert.doesNotThrow(function() {
let decompressed = zlib[methods.decompSync](compressed);
const decompressed = zlib[methods.decompSync](compressed);
assert.equal(decompressed, inputString);
});

Expand Down
4 changes: 2 additions & 2 deletions test/sequential/test-child-process-fork-getconnections.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const net = require('net');
const count = 12;

if (process.argv[2] === 'child') {
let sockets = [];
const sockets = [];

process.on('message', function(m, socket) {
function sendClosed(id) {
Expand Down Expand Up @@ -42,7 +42,7 @@ if (process.argv[2] === 'child') {
});

const server = net.createServer();
let sockets = [];
const sockets = [];
let sent = 0;

server.on('connection', function(socket) {
Expand Down

0 comments on commit 6e887cc

Please sign in to comment.