Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency pino to v9 #1919

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(deps): update dependency pino to v9 #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"license": "AGPL-3.0",
"dependencies": {
"fastify": "^4.27.0",
"pino": "^8.18.0",
Copy link

@codecov codecov bot May 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the 'pino' package was updated from 8.18.0 to 9.0.0. It is important to note that this is a major version change which can bring breaking changes. It is recommended to review the changelog of the updated package to ensure compatibility with the existing codebase.

"pino": "^9.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also 'pino' is updated to v9 in the shared package. Do the same verifications regarding breaking changes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've updated Pino in your shared package as well. Make sure that this does not cause any incompatibility issues with other packages or applications using your shared package.

Copy link

@codecov codecov bot Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've upgraded pino logging library from version 8.18.0 to 9.0.0. Note that whenever we upgrade dependencies to a new major version, we should analyse the breaking changes introduced in that version to estimate the potential impact on our application. Review the library's changelog or release notes for any breaking changes. Also, run all the tests to make sure those updates do not break the application.

"pino-pretty": "^11.0.0",
Copy link

@codecov codecov bot May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm 'pino-pretty' version 11.0.0 is compatible with 'pino' version 9.0.0. Although not every single major update will result in issues with dependent libraries, when it does occur it can cause unexpected behaviour.

"vitest": "^1.6.0"
},
Expand Down
Loading