Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consuming a struct and returning a slice #662

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

alexcrichton
Copy link
Contributor

This came up in a recent comment and it turns out we're accidentally
generating two const ptr = ... declarations, invalid JS! While Node doesn't
catch this it looks like firefox does.

This came up in a [recent comment][1] and it turns out we're accidentally
generating two `const ptr = ...` declarations, invalid JS! While Node doesn't
catch this it looks like firefox does.

[1]: rustwasm#329 (comment)
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fitzgen fitzgen merged commit 9b65e57 into rustwasm:master Aug 7, 2018
@alexcrichton alexcrichton deleted the consume-ret-string branch August 20, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants