Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to run tests on remote webdriver. #1744

Merged
merged 6 commits into from
Sep 19, 2019
Merged

Add ability to run tests on remote webdriver. #1744

merged 6 commits into from
Sep 19, 2019

Conversation

Kirguir
Copy link
Contributor

@Kirguir Kirguir commented Aug 29, 2019

Resolve #1731, #1732

  • added parsing env vars like GECKODRIVER_REMOTE for address of remote webdriver
  • removed parsing env vars like GECKODRIVER_CLIENT_ARGS
  • added parsing a file webdriver.json for configure browser's capabilities, like:
{
  "moz:firefoxOptions": {
    "prefs": {
      "media.navigator.streams.fake": true,
      "media.navigator.permission.disabled": true,
    },
    "args": []
  },
  "goog:chromeOptions": {
    "args": [
      "--use-fake-device-for-media-stream",
      "--use-fake-ui-for-media-stream"
    ]
  }
}

@alexcrichton
Copy link
Contributor

Thanks for this and sorry for the delay in reviewing! This is getting complicated enough that would you mind writing up a page in guide/* about all the various options to configure this? Also is the webdriver dependency here necessary, or could we perhaps continue to use raw json blobs using just serde?

@Kirguir
Copy link
Contributor Author

Kirguir commented Sep 9, 2019

You can use a raw JSON blob, as shown in the example - each browser will only process its own section of options.
Of course I will add a configuration description to this guide.

@alexcrichton
Copy link
Contributor

Thanks! And I'm just thinking that the webdriver dependency isn't really buying us much since it's just a few structures, so would it be possible to remove the dependency on it? Additionally do you know if there's documentation for safari's supported options?

@Kirguir
Copy link
Contributor Author

Kirguir commented Sep 16, 2019

For Safari, unfortunately, did not find anything. Do you mean remove webdriver from here?

@alexcrichton
Copy link
Contributor

Ah ok, seems fine to start out with chrome/firefox in any case. And yeah by removing webdriver I mean the crate used as a dependency.

@alexcrichton alexcrichton merged commit eeebec0 into rustwasm:master Sep 19, 2019
@alexcrichton
Copy link
Contributor

Looks great to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options for webdriver
2 participants