Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an accessor for the function table #1431

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

alexcrichton
Copy link
Contributor

This commit adds an intrinsics to the wasm_bindgen crate which
accesses the WebAssembly.Table which is the function table of the
module. Eventually the thinking is that a module would import its own
function table via native wasm functionality (via anyref and such),
but until that's implemented let's add a binding for it ourselves!

Closes #1427

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One testing suggestion below.

tests/wasm/api.js Outdated Show resolved Hide resolved
This commit adds an intrinsics to the `wasm_bindgen` crate which
accesses the `WebAssembly.Table` which is the function table of the
module. Eventually the thinking is that a module would import its own
function table via native wasm functionality (via `anyref` and such),
but until that's implemented let's add a binding for it ourselves!

Closes rustwasm#1427
@alexcrichton alexcrichton merged commit b670ea4 into rustwasm:master Apr 8, 2019
@alexcrichton alexcrichton deleted the function-table branch April 8, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants